OneSizeFitsQuorum commented on code in PR #14362:
URL: https://github.com/apache/iotdb/pull/14362#discussion_r1881760230
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensus.java:
##########
@@ -296,53 +296,55 @@ public void addRemotePeer(ConsensusGroupId groupId, Peer
peer) throws ConsensusE
IoTConsensusServerImpl impl =
Optional.ofNullable(stateMachineMap.get(groupId))
.orElseThrow(() -> new ConsensusGroupNotExistException(groupId));
- if (impl.getConfiguration().contains(peer)) {
- throw new PeerAlreadyInConsensusGroupException(groupId, peer);
- }
- try {
- // step 1: inactive new Peer to prepare for following steps
- logger.info("[IoTConsensus] inactivate new peer: {}", peer);
- impl.inactivePeer(peer, false);
+ synchronized (impl) {
Review Comment:
we should add this for remove and resetPeerList too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
