Caideyipi commented on code in PR #14386:
URL: https://github.com/apache/iotdb/pull/14386#discussion_r1883420912
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/ShowPipes.java:
##########
@@ -24,17 +24,23 @@
import java.util.Objects;
import static com.google.common.base.MoreObjects.toStringHelper;
+import static java.util.Objects.requireNonNull;
public class ShowPipes extends PipeStatement {
private final String pipeName;
private final boolean hasWhereClause;
+ private String sqlDialect;
public ShowPipes(final @Nullable String pipeName, final boolean
hasWhereClause) {
this.pipeName = pipeName;
this.hasWhereClause = hasWhereClause;
}
+ public void setSqlDialect(final String sqlDialect) {
Review Comment:
Do we really need to add the "set" here? Maybe we can actually identify the
"statement" without "Statement" suffix as table model statement, and tree
statement if with it. I think we better put the "isTableModel" as a boolean in
"AlterPipeTask" instead of a string in statements.
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -1110,18 +1113,37 @@ public TSStatus alterPipe(TAlterPipeReq req) {
@Override
public TSStatus startPipe(String pipeName) {
- return configManager.startPipe(pipeName);
+ return configManager.startPipe(
+ new TStartPipeReq()
+ .setPipeName(pipeName)
+ .setSqlDialect(SystemConstant.SQL_DIALECT_TREE_VALUE));
Review Comment:
Seemingly there are no need for us to support rolling upgrade, because we do
not support rolling upgrade from 1.3 -> 2.0, and from 2.0 beta -> 2.0 we do not
support upgrading with any table model data....
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/pipe/PipeTaskInfo.java:
##########
@@ -349,6 +343,15 @@ public boolean isPipeExisted(final String pipeName) {
}
}
+ public boolean isPipeExisted(final String pipeName, final String sqlDialect)
{
Review Comment:
Better use "pipeExists"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
