HxpSerein commented on code in PR #14738:
URL: https://github.com/apache/iotdb/pull/14738#discussion_r1924645400
##########
iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/manager/load/LoadManagerTest.java:
##########
@@ -237,7 +237,7 @@ public void testRegionGroupCache() throws
InterruptedException {
allRunningRegionStatisticsMap.put(addDataNodeId, new
RegionStatistics(RegionStatus.Running));
Assert.assertEquals(
new Pair<>(
- new RegionGroupStatistics(RegionGroupStatus.Available,
oneRemovingRegionStatisticsMap),
Review Comment:
these tests are already included in `RegionGroupCacheTest`
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/LoadCache.java:
##########
@@ -165,13 +170,21 @@ private void initRegionGroupHeartbeatCache(
regionReplicaSets.forEach(
regionReplicaSet -> {
TConsensusGroupId regionGroupId =
regionReplicaSet.getRegionId();
+ boolean isStrongConsistency =
+
(TConsensusGroupType.SchemaRegion.equals(regionGroupId.getType())
Review Comment:
done
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/RegionGroupStatus.java:
##########
@@ -24,24 +24,15 @@ public enum RegionGroupStatus {
Running("Running", 1),
/**
- * All Regions in RegionGroup are in the Running or Unknown or Removing
status, and the number of
- * Regions in the Unknown or Removing status is less than half
+ * For strong consistency algorithms, the RegionGroup is considered as
Available when the number
+ * of Regions in the Running status is greater than half. For weak
consistency algorithms, the
+ * RegionGroup is considered as Available when the number of Regions in the
Running status is
+ * greater than or equal to 1.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
