FearfulTomcat27 commented on code in PR #14755:
URL: https://github.com/apache/iotdb/pull/14755#discussion_r1948026465
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/TableMetadataImpl.java:
##########
@@ -884,6 +894,28 @@ public static boolean isTwoTypeComparable(List<? extends
Type> argumentTypes) {
|| ((isNumericType(left) || isCharType(left)) && isUnknownType(right));
}
+ public static boolean areAllTypesSameAndComparable(List<? extends Type>
argumentTypes) {
+ if (argumentTypes == null || argumentTypes.isEmpty()) {
+ return true;
+ }
+ Type firstType = argumentTypes.get(0);
+ if (!firstType.isComparable()) {
+ return false;
+ }
+ return argumentTypes.stream().allMatch(type -> type.equals(firstType));
+ }
+
+ public static boolean isAllTypeComparable(List<? extends Type>
argumentTypes) {
+ Type firstType = argumentTypes.get(0);
+ boolean flag = true;
+ for (Type type : argumentTypes) {
+ if (!isTwoTypeComparable(Arrays.asList(firstType, type))) {
+ flag = false;
+ }
+ }
+ return flag;
+ }
+
Review Comment:
delete this function
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/multi/AbstractGreatestLeastColumnTransformer.java:
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.transformation.dag.column.multi;
+
+import
org.apache.iotdb.db.queryengine.transformation.dag.column.ColumnTransformer;
+
+import org.apache.tsfile.block.column.Column;
+import org.apache.tsfile.block.column.ColumnBuilder;
+import org.apache.tsfile.read.common.type.Type;
+import org.apache.tsfile.read.common.type.TypeEnum;
+
+import java.util.List;
+
+public abstract class AbstractGreatestLeastColumnTransformer extends
MultiColumnTransformer {
+
+ protected AbstractGreatestLeastColumnTransformer(
+ Type returnType, List<ColumnTransformer> columnTransformerList) {
+ super(returnType, columnTransformerList);
+ }
+
+ @Override
+ protected void doTransform(
+ List<Column> childrenColumns, ColumnBuilder builder, int positionCount) {
+ for (int i = 0; i < positionCount; i++) {
+ final int index = i;
+ if (childrenColumns.stream().allMatch(column -> column.isNull(index))) {
+ builder.appendNull();
+ continue;
+ }
+
+ transform(builder, childrenColumns, index);
+ }
+ }
+
+ @Override
+ protected void doTransform(
+ List<Column> childrenColumns, ColumnBuilder builder, int positionCount,
boolean[] selection) {
+ for (int i = 0; i < positionCount; i++) {
+ final int index = i;
+ if (selection[index] || childrenColumns.stream().allMatch(column ->
column.isNull(index))) {
+ builder.appendNull();
+ continue;
+ }
+ transform(builder, childrenColumns, index);
+ }
+ }
+
+ protected abstract void transform(ColumnBuilder builder, List<Column>
childrenColumns, int index);
+
+ public static ColumnTransformer getGreatestColumnTransformer(
+ Type type, List<ColumnTransformer> columnTransformers) {
+ TypeEnum typeEnum = type.getTypeEnum();
+ switch (typeEnum) {
+ case BOOLEAN:
+ return new BooleanGreatestColumnTransformer(type, columnTransformers);
+ case INT32:
+ case DATE:
+ return new Int32GreatestColumnTransformer(type, columnTransformers);
+ case INT64:
+ case TIMESTAMP:
+ return new Int64GreatestColumnTransformer(type, columnTransformers);
+ case FLOAT:
+ return new FloatGreatestColumnTransformer(type, columnTransformers);
+ case DOUBLE:
+ return new DoubleGreatestColumnTransformer(type, columnTransformers);
+ case STRING:
+ case TEXT:
+ return new BinaryGreatestColumnTransformer(type, columnTransformers);
+ default:
+ throw new UnsupportedOperationException(
+ String.format("Unsupported data type: %s", typeEnum));
+ }
+ }
+
+ public static ColumnTransformer getLeastColumnTransformer(
+ Type type, List<ColumnTransformer> columnTransformers) {
+ TypeEnum typeEnum = type.getTypeEnum();
+ switch (typeEnum) {
+ case BOOLEAN:
+ return new BooleanLeastColumnTransformer(type, columnTransformers);
+ case INT32:
+ case DATE:
+ return new Int32LeastColumnTransformer(type, columnTransformers);
+ case INT64:
+ case TIMESTAMP:
+ return new Int64LeastColumnTransformer(type, columnTransformers);
+ case FLOAT:
+ return new FloatLeastColumnTransformer(type, columnTransformers);
+ case DOUBLE:
+ return new DoubleLeastColumnTransformer(type, columnTransformers);
+ case STRING:
+ case TEXT:
+ return new BinaryLeastColumnTransformer(type, columnTransformers);
+ default:
+ throw new UnsupportedOperationException(
+ String.format("Unsupported data type: %s", typeEnum));
+ }
+ }
+
+ // protected void transform(ColumnBuilder builder, List<Column>
childrenColumns, int i) {
+ // TypeEnum type = columnTransformerList.get(0).getType().getTypeEnum();
+ // switch (type) {
+ // case BOOLEAN:
+ // transformBoolean(builder, getValues(childrenColumns, i,
Column::getBoolean));
+ // break;
+ // case INT32:
+ // case DATE:
+ // transformInt(builder, getValues(childrenColumns, i,
Column::getInt));
+ // break;
+ // case INT64:
+ // case TIMESTAMP:
+ // transformLong(builder, getValues(childrenColumns, i,
Column::getLong));
+ // break;
+ // case FLOAT:
+ // transformFloat(builder, getValues(childrenColumns, i,
Column::getFloat));
+ // break;
+ // case DOUBLE:
+ // transformDouble(builder, getValues(childrenColumns, i,
Column::getDouble));
+ // break;
+ // case STRING:
+ // case TEXT:
+ // transformBinary(builder, getValues(childrenColumns, i,
Column::getBinary));
+ // break;
+ // default:
+ // throw new UnsupportedOperationException(
+ // String.format("Unsupported data type: %s",
returnType.getTypeEnum()));
+ // }
+ // }
+
+ // private <T> List<T> getValues(List<Column> columns, int index,
ValueExtractor<T> extractor) {
+ // List<T> values = new ArrayList<>();
+ // for (Column column : columns) {
+ // if (!column.isNull(index)) {
+ // values.add(extractor.extract(column, index));
+ // }
+ // }
+ // return values;
+ // }
+ //
+ // @FunctionalInterface
+ // private interface ValueExtractor<T> {
+ // T extract(Column column, int index);
+ // }
+
+ // protected abstract void transformBoolean(ColumnBuilder builder,
List<Boolean> values);
+ //
+ // protected abstract void transformInt(ColumnBuilder builder,
List<Integer> values);
+ //
+ // protected abstract void transformLong(ColumnBuilder builder, List<Long>
values);
+ //
+ // protected abstract void transformFloat(ColumnBuilder builder,
List<Float> values);
+ //
+ // protected abstract void transformDouble(ColumnBuilder builder,
List<Double> values);
+ //
+ // protected abstract void transformBinary(ColumnBuilder builder,
List<Binary> values);
Review Comment:
delete those comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
