DanielWang2035 commented on code in PR #14751:
URL: https://github.com/apache/iotdb/pull/14751#discussion_r1952310508


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileAnalyzer.java:
##########
@@ -65,64 +95,111 @@ public abstract class LoadTsFileAnalyzer implements 
AutoCloseable {
 
   private final boolean isGeneratedByPipe;
 
-  protected final List<File> tsFiles;
-  protected final String statementString;
-  protected final boolean isVerifySchema;
+  private final List<File> tsFiles;
+  private final List<Boolean> isTableModel;
+  private final String statementString;
+  private final boolean isVerifySchema;
 
-  protected final boolean isDeleteAfterLoad;
+  private final boolean isDeleteAfterLoad;
 
-  protected final boolean isConvertOnTypeMismatch;
+  private final boolean isConvertOnTypeMismatch;
 
-  protected final boolean isAutoCreateDatabase;
+  private final boolean isAutoCreateDatabase;
 
-  protected final int databaseLevel;
+  private final int databaseLevel;
 
-  protected final String database;
+  private String databaseForTableData;
 
   final MPPQueryContext context;
 
   final IPartitionFetcher partitionFetcher = 
ClusterPartitionFetcher.getInstance();
   final ISchemaFetcher schemaFetcher = ClusterSchemaFetcher.getInstance();
+  private final Metadata metadata = 
LocalExecutionPlanner.getInstance().metadata;
+  private final AccessControl accessControl = 
Coordinator.getInstance().getAccessControl();
+  private TreeSchemaAutoCreatorAndVerifier schemaAutoCreatorAndVerifier;
+  private LoadTsFileTableSchemaCache schemaCache;
 
-  LoadTsFileAnalyzer(
+  public LoadTsFileAnalyzer(
       LoadTsFileStatement loadTsFileStatement, boolean isGeneratedByPipe, 
MPPQueryContext context) {
     this.loadTsFileTreeStatement = loadTsFileStatement;
     this.tsFiles = loadTsFileStatement.getTsFiles();
+    this.isTableModel = new 
ArrayList<>(Collections.nCopies(this.tsFiles.size(), false));
     this.statementString = loadTsFileStatement.toString();
     this.isVerifySchema = loadTsFileStatement.isVerifySchema();
     this.isDeleteAfterLoad = loadTsFileStatement.isDeleteAfterLoad();
     this.isConvertOnTypeMismatch = 
loadTsFileStatement.isConvertOnTypeMismatch();
     this.isAutoCreateDatabase = loadTsFileStatement.isAutoCreateDatabase();
     this.databaseLevel = loadTsFileStatement.getDatabaseLevel();
-    this.database = loadTsFileStatement.getDatabase();
+    this.databaseForTableData = loadTsFileStatement.getDatabase();
 
     this.loadTsFileTableStatement = null;
     this.isTableModelStatement = false;
     this.isGeneratedByPipe = isGeneratedByPipe;
     this.context = context;
   }
 
-  LoadTsFileAnalyzer(
+  public LoadTsFileAnalyzer(
       LoadTsFile loadTsFileTableStatement, boolean isGeneratedByPipe, 
MPPQueryContext context) {
     this.loadTsFileTableStatement = loadTsFileTableStatement;
     this.tsFiles = loadTsFileTableStatement.getTsFiles();
+    this.isTableModel = new 
ArrayList<>(Collections.nCopies(this.tsFiles.size(), false));
     this.statementString = loadTsFileTableStatement.toString();
     this.isVerifySchema = loadTsFileTableStatement.isVerifySchema();
     this.isDeleteAfterLoad = loadTsFileTableStatement.isDeleteAfterLoad();
     this.isConvertOnTypeMismatch = 
loadTsFileTableStatement.isConvertOnTypeMismatch();
     this.isAutoCreateDatabase = 
loadTsFileTableStatement.isAutoCreateDatabase();
     this.databaseLevel = loadTsFileTableStatement.getDatabaseLevel();
-    this.database = loadTsFileTableStatement.getDatabase();
+    this.databaseForTableData = loadTsFileTableStatement.getDatabase();
 
     this.loadTsFileTreeStatement = null;
     this.isTableModelStatement = true;
     this.isGeneratedByPipe = isGeneratedByPipe;
     this.context = context;
   }
 
-  public abstract IAnalysis analyzeFileByFile(IAnalysis analysis);
+  public IAnalysis analyzeFileByFile(IAnalysis analysis) {
+    checkBeforeAnalyzeFileByFile(analysis);
+    if (analysis.isFinishQueryAfterAnalyze()) {
+      return analysis;
+    }
+
+    if (!doAnalyzeFileByFile(analysis)) {
+      // return false means the analysis is failed because of exception
+      return analysis;
+    }
+
+    try {
+      // flush remaining metadata of tree-model, currently no need for 
table-model
+      if (schemaAutoCreatorAndVerifier != null) {
+        schemaAutoCreatorAndVerifier.flush();
+      }
+    } catch (AuthException e) {
+      setFailAnalysisForAuthException(analysis, e);
+      return analysis;
+    } catch (LoadAnalyzeException e) {
+      executeTabletConversion(analysis, e);

Review Comment:
   refactor executeTabletConversion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to