SteveYurongSu commented on code in PR #14964:
URL: https://github.com/apache/iotdb/pull/14964#discussion_r1973156745
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/plugin/dataregion/PipeDataRegionConnectorConstructor.java:
##########
@@ -91,6 +94,7 @@ protected void initConstructors() {
pluginConstructors.put(
BuiltinPipePlugin.WEBSOCKET_SINK.getPipePluginName(),
WebSocketConnector::new);
pluginConstructors.put(BuiltinPipePlugin.OPC_UA_SINK.getPipePluginName(),
OpcUaConnector::new);
+ pluginConstructors.put(BuiltinPipePlugin.OPC_DA_SINK.getPipePluginName(),
OPCDAConnector::new);
Review Comment:
```suggestion
pluginConstructors.put(BuiltinPipePlugin.OPC_UA_SINK.getPipePluginName(),
OpcUaConnector::new);
pluginConstructors.put(BuiltinPipePlugin.OPC_DA_SINK.getPipePluginName(),
OpcDaConnector::new);
```
?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/opcda/OPCDAConnector.java:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.pipe.connector.protocol.opcda;
+
+import org.apache.iotdb.db.pipe.connector.protocol.opcua.OpcUaConnector;
+import org.apache.iotdb.pipe.api.PipeConnector;
+import org.apache.iotdb.pipe.api.annotation.TreeModel;
+import
org.apache.iotdb.pipe.api.customizer.configuration.PipeConnectorRuntimeConfiguration;
+import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameterValidator;
+import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameters;
+import org.apache.iotdb.pipe.api.event.Event;
+import org.apache.iotdb.pipe.api.event.dml.insertion.TabletInsertionEvent;
+
+import org.apache.tsfile.utils.Pair;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import static
org.apache.iotdb.commons.pipe.config.constant.PipeConnectorConstant.CONNECTOR_OPC_DA_CLSID_KEY;
+import static
org.apache.iotdb.commons.pipe.config.constant.PipeConnectorConstant.CONNECTOR_OPC_DA_PROGID_KEY;
+import static
org.apache.iotdb.commons.pipe.config.constant.PipeConnectorConstant.SINK_OPC_DA_CLSID_KEY;
+import static
org.apache.iotdb.commons.pipe.config.constant.PipeConnectorConstant.SINK_OPC_DA_PROGID_KEY;
+
+/**
+ * Send data in IoTDB based on Opc Da protocol, using JNA. All data are
converted into tablets, and
+ * then push the newest value to the <b>local COM</b> server in another
process.
+ */
+@TreeModel
+public class OPCDAConnector implements PipeConnector {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(OPCDAConnector.class);
+ private static final Map<String, Pair<AtomicInteger, OPCDAServerHandle>>
+ CLS_ID_TO_REFERENCE_COUNT_AND_HANDLE_MAP = new ConcurrentHashMap<>();
+ private String clsID;
+ private OPCDAServerHandle handle;
+
+ @Override
+ public void validate(final PipeParameterValidator validator) throws
Exception {
+ // TODO: upgrade this logic after "1 in 2" logic is supported
+ validator.validate(
+ args ->
+ (((boolean) args[1] || (boolean) args[2] || (boolean) args[3] ||
(boolean) args[4])),
+ String.format(
+ "One of '%s', '%s', '%s' and '%s' must be specified",
+ SINK_OPC_DA_CLSID_KEY,
+ CONNECTOR_OPC_DA_CLSID_KEY,
+ SINK_OPC_DA_PROGID_KEY,
+ CONNECTOR_OPC_DA_PROGID_KEY),
+ validator.getParameters().hasAttribute(SINK_OPC_DA_CLSID_KEY),
+ validator.getParameters().hasAttribute(CONNECTOR_OPC_DA_CLSID_KEY),
+ validator.getParameters().hasAttribute(SINK_OPC_DA_PROGID_KEY),
+ validator.getParameters().hasAttribute(CONNECTOR_OPC_DA_PROGID_KEY));
+ }
+
+ @Override
+ public void customize(
+ final PipeParameters parameters, final PipeConnectorRuntimeConfiguration
configuration)
+ throws Exception {
+ synchronized (CLS_ID_TO_REFERENCE_COUNT_AND_HANDLE_MAP) {
+ clsID = parameters.getStringByKeys(CONNECTOR_OPC_DA_CLSID_KEY,
SINK_OPC_DA_CLSID_KEY);
+ if (Objects.isNull(clsID)) {
+ clsID =
+ OPCDAServerHandle.getClsIDFromProgID(
+ parameters.getStringByKeys(CONNECTOR_OPC_DA_PROGID_KEY,
SINK_OPC_DA_PROGID_KEY));
+ }
+ handle =
+ CLS_ID_TO_REFERENCE_COUNT_AND_HANDLE_MAP
+ .computeIfAbsent(
+ clsID, key -> new Pair<>(new AtomicInteger(0), new
OPCDAServerHandle(clsID)))
+ .getRight();
+
CLS_ID_TO_REFERENCE_COUNT_AND_HANDLE_MAP.get(clsID).getLeft().incrementAndGet();
+ }
+ }
+
+ @Override
+ public void handshake() throws Exception {
+ // Do nothing
+ }
+
+ @Override
+ public void heartbeat() throws Exception {
+ // Do nothing
+ }
+
+ @Override
+ public void transfer(final TabletInsertionEvent tabletInsertionEvent) throws
Exception {
+ OpcUaConnector.transferByTablet(
Review Comment:
OpcUaConnector here is not very elegant :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
