JackieTien97 commented on code in PR #15333:
URL: https://github.com/apache/iotdb/pull/15333#discussion_r2041858325
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java:
##########
@@ -2289,7 +2296,29 @@ public Node
visitTableArgumentTable(RelationalSqlParser.TableArgumentTableContex
}
@Override
- public Node
visitTableArgumentQuery(RelationalSqlParser.TableArgumentQueryContext context) {
+ public Node
visitTableArgumentTable(RelationalSqlParser.TableArgumentTableContext context) {
+ Relation relation =
+ new Table(getLocation(context.qualifiedName()),
getQualifiedName(context.qualifiedName()));
+
+ if (context.identifier() != null) {
+ Identifier alias = (Identifier) visit(context.identifier());
+ if (context.AS() == null) {
+ validateArgumentAlias(alias, context.identifier());
+ }
+ List<Identifier> columnNames = null;
+ if (context.columnAliases() != null) {
+ columnNames = visit(context.columnAliases().identifier(),
Identifier.class);
+ }
+ relation =
+ new AliasedRelation(getLocation(context.qualifiedName()), relation,
alias, columnNames);
+ }
+
+ return relation;
+ }
Review Comment:
extract common codes with visitTableArgumentTableWithTableKeyWord
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java:
##########
@@ -2308,6 +2337,26 @@ public Node
visitTableArgumentQuery(RelationalSqlParser.TableArgumentQueryContex
return relation;
}
+ @Override
+ public Node
visitTableArgumentQuery(RelationalSqlParser.TableArgumentQueryContext context) {
+ Relation relation =
+ new TableSubquery(getLocation(context.query()), (Query)
visit(context.query()));
+
+ if (context.identifier() != null) {
+ Identifier alias = (Identifier) visit(context.identifier());
+ if (context.AS() == null) {
+ validateArgumentAlias(alias, context.identifier());
+ }
+ List<Identifier> columnNames = null;
+ if (context.columnAliases() != null) {
+ columnNames = visit(context.columnAliases().identifier(),
Identifier.class);
+ }
+ relation = new AliasedRelation(getLocation(context.query()), relation,
alias, columnNames);
+ }
+
+ return relation;
Review Comment:
extract common codes with visitTableArgumentQueryWithTableKeyWord
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
