shuwenwei commented on code in PR #14617:
URL: https://github.com/apache/iotdb/pull/14617#discussion_r2050416859
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableDeviceSchemaFetcher.java:
##########
@@ -467,6 +511,68 @@ private void fetchMissingDeviceSchemaForQuery(
}
}
+ private void constructTableResults(
+ final TsBlock tsBlock,
+ final List<ColumnHeader> columnHeaderList,
+ final TsTable tableInstance,
+ final ShowDevice statement,
+ final MPPQueryContext mppQueryContext,
+ final List<String> attributeColumns,
+ final List<DeviceEntry> deviceEntryList) {
+ final Column[] columns = tsBlock.getValueColumns();
+ for (int i = 0; i < tsBlock.getPositionCount(); i++) {
+ final String[] nodes = new String[tableInstance.getIdNums() + 1];
+ final Map<String, Binary> attributeMap = new HashMap<>();
+ constructNodsArrayAndAttributeMap(
+ attributeMap,
+ nodes,
+ tableInstance.getTableName(),
+ columnHeaderList,
+ columns,
+ tableInstance,
+ i);
+ final IDeviceID deviceID =
IDeviceID.Factory.DEFAULT_FACTORY.create(nodes);
+ final AlignedDeviceEntry deviceEntry =
+ new AlignedDeviceEntry(
+ deviceID,
attributeColumns.stream().map(attributeMap::get).toArray(Binary[]::new));
+ mppQueryContext.reserveMemoryForFrontEnd(deviceEntry.ramBytesUsed());
+ deviceEntryList.add(deviceEntry);
+ // Only cache those exact device query
+ // Fetch paths is null iff there are fuzzy queries related to id columns
+ if (Objects.nonNull(statement.getPartitionKeyList())) {
+ cache.putAttributes(statement.getDatabase(), deviceID, attributeMap);
+ }
+ }
+ }
+
+ private void constructTreeResults(
+ final TsBlock tsBlock,
+ final List<ColumnHeader> columnHeaderList,
+ final TsTable tableInstance,
+ final MPPQueryContext mppQueryContext,
+ final List<DeviceEntry> deviceEntryList) {
+ final Column[] columns = tsBlock.getValueColumns();
+ for (int i = 0; i < tsBlock.getPositionCount(); i++) {
+ final String[] nodes = new String[tableInstance.getIdNums() + 1];
Review Comment:
Here and in the following lines of code, it seems that the table view name
is spelled into the IDeviceID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
