JackieTien97 commented on code in PR #14423:
URL: https://github.com/apache/iotdb/pull/14423#discussion_r2111294164
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/window/utils/RowComparator.java:
##########
@@ -49,6 +49,7 @@ public boolean equal(Column column, int offset1, int offset2)
{
return equal(column, dataTypes.get(0), offset1, offset2);
}
+ // TODO: need to add timestamp and other data types
Review Comment:
remove this todo, @Sh-Zh-7 has already fixed it in
https://github.com/apache/iotdb/pull/15151
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java:
##########
@@ -3115,6 +3142,216 @@ public Operator visitTableFunctionProcessor(
}
}
+ // TODO
Review Comment:
todo for what? TODO is never allowed in iotdb, it will be checked throught CI
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java:
##########
@@ -3115,6 +3142,216 @@ public Operator visitTableFunctionProcessor(
}
}
+ // TODO
Review Comment:
todo for what? TODO is never allowed in iotdb, it will be checked throught CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
