Copilot commented on code in PR #15923: URL: https://github.com/apache/iotdb/pull/15923#discussion_r2202476317
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/DropModel.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.plan.relational.sql.ast; + +import java.util.List; +import java.util.Objects; + +public class DropModel extends Statement { + + private final String modelId; + + public DropModel(String modelId) { + super(null); + this.modelId = modelId; + } + + public String getModelId() { + return modelId; + } + + @Override + public <R, C> R accept(AstVisitor<R, C> visitor, C context) { + return visitor.visitDropModel(this, context); + } + + @Override + public List<? extends Node> getChildren() { + return null; Review Comment: getChildren() returns null, which can cause NullPointerExceptions during AST traversal. Consider returning Collections.emptyList() instead. ```suggestion return Collections.emptyList(); ``` ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/CreateModel.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.plan.relational.sql.ast; + +import java.util.List; +import java.util.Objects; + +public class CreateModel extends Statement { + + private final String modelId; + private final String uri; + + public CreateModel(String modelId, String uri) { + super(null); + this.modelId = modelId; + this.uri = uri; + } + + public String getModelId() { + return modelId; + } + + public String getUri() { + return uri; + } + + @Override + public <R, C> R accept(AstVisitor<R, C> visitor, C context) { + return visitor.visitCreateModel(this, context); + } + + @Override + public List<? extends Node> getChildren() { + return null; Review Comment: getChildren() returns null, which can cause NullPointerExceptions during AST traversal. Consider returning Collections.emptyList() instead. ```suggestion return Collections.emptyList(); ``` ########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ModelManager.java: ########## @@ -82,7 +82,7 @@ public TSStatus createModel(TCreateModelReq req) { public TSStatus dropModel(TDropModelReq req) { if (modelInfo.checkModelType(req.getModelId()) != ModelType.USER_DEFINED) { - return new TSStatus(TSStatusCode.MODEL_EXIST_ERROR.getStatusCode()) + return new TSStatus(TSStatusCode.DROP_MODEL_ERROR.getStatusCode()) Review Comment: Switching from MODEL_EXIST_ERROR to DROP_MODEL_ERROR changes the status code in the error prefix. Update integration tests or align the code so that the reported error code matches test expectations. ```suggestion return new TSStatus(TSStatusCode.MODEL_EXIST_ERROR.getStatusCode()) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
