Copilot commented on code in PR #15961:
URL: https://github.com/apache/iotdb/pull/15961#discussion_r2212452658
##########
scripts/tools/tsfile/validate-tsfile.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.validate.TsFileValidationTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"$MAIN_CLASS" "$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/tsfile/print-tsfile.sh:
##########
@@ -41,12 +41,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.TsFileSketchTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"$MAIN_CLASS" "$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/tsfile/split-tsfile-tool.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.TsFileSplitTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"$MAIN_CLASS" "$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/tsfile/check-overlap-sequence-files-and-repair.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.validate.TsFileOverlapValidationAndRepairTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"$MAIN_CLASS" "$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/schema/print-schema-log.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.schema.MLogParser
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"$MAIN_CLASS" "$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/tsfile/settle-tsfile.sh:
##########
@@ -37,12 +37,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.settle.TsFileSettleByCompactionTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"$MAIN_CLASS" "$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/tsfile/print-iotdb-data-dir.sh:
##########
@@ -41,12 +41,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.IoTDBDataDirViewer
-"$JAVA" -cp "$CLASSPATH"
"-Dlogback.configurationFile=${IOTDB_HOME}/conf/logback-tool.xml" "$MAIN_CLASS"
"$@"
+"$JAVA" -cp "$CLASSPATH"
"-Dlogback.configurationFile=${IOTDB_HOME}/conf/logback-tool.xml" "$JVM_OPTS"
"$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"-Dlogback.configurationFile=${IOTDB_HOME}/conf/logback-tool.xml" "$MAIN_CLASS"
"$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"-Dlogback.configurationFile=${IOTDB_HOME}/conf/logback-tool.xml" "$MAIN_CLASS"
"$@"
```
##########
scripts/tools/ops/backup.sh:
##########
@@ -136,4 +138,4 @@ fi
IOTDB_CLI_CONF=${IOTDB_HOME}/conf
iotdb_cli_params="-Dlogback.configurationFile=${IOTDB_CLI_CONF}/logback-backup.xml"
-exec nohup "$JAVA" -DIOTDB_HOME=${IOTDB_HOME} $iotdb_cli_params -cp
"$CLASSPATH" "$MAIN_CLASS" "$@" >/dev/null 2>&1 <&- &
+exec nohup "$JAVA" $JAVA_OPTS -DIOTDB_HOME=${IOTDB_HOME} $iotdb_cli_params -cp
"$CLASSPATH" "$MAIN_CLASS" "$@" >/dev/null 2>&1 <&- &
Review Comment:
The variable name $JAVA_OPTS is incorrect and should be $JVM_OPTS to match
the variable defined earlier in the script.
```suggestion
exec nohup "$JAVA" $JVM_OPTS -DIOTDB_HOME=${IOTDB_HOME} $iotdb_cli_params
-cp "$CLASSPATH" "$MAIN_CLASS" "$@" >/dev/null 2>&1 <&- &
```
##########
scripts/tools/schema/print-pb-tree-file.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.schema.PBTreeFileSketchTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
The JVM_OPTS variable is incorrectly quoted and positioned. It should be
unquoted and placed before the -cp option: "$JAVA" $JVM_OPTS -cp "$CLASSPATH"
"$MAIN_CLASS" "$@"
```suggestion
"$JAVA" $JVM_OPTS -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
