JackieTien97 commented on code in PR #15685:
URL: https://github.com/apache/iotdb/pull/15685#discussion_r2224505623
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TableIntoOperator.java:
##########
@@ -111,10 +111,15 @@ protected TsBlock tryToReturnResultTsBlock() {
@Override
public long ramBytesUsed() {
Review Comment:
I think we still need to update the `calculateMaxPeekMemory`,
`calculateMaxReturnSize` and `calculateRetainedSizeAfterCallingNext`
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java:
##########
@@ -650,16 +649,16 @@ protected Scope visitInsert(Insert insert,
Optional<Scope> scope) {
.collect(toImmutableList());
analysis.registerTable(insert.getTable(), tableSchema, targetTable);
- List<String> tableColumns =
-
columns.stream().map(ColumnSchema::getName).collect(toImmutableList());
+ Set<String> tableColumns =
+
columns.stream().map(ColumnSchema::getName).collect(toImmutableSet());
- List<String> insertColumns;
+ Set<String> insertColumns;
Review Comment:
I think we need to keep the order of insertColumns? so maybe `LinkedHashSet`
will be the best choice?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TableIntoOperator.java:
##########
@@ -111,10 +111,15 @@ protected TsBlock tryToReturnResultTsBlock() {
@Override
public long ramBytesUsed() {
+ System.out.println("***********************");
+ System.out.println("INSTANCE_SIZE: " + INSTANCE_SIZE);
+ System.out.println(
+ "insertTabletStatementGenerator: " +
insertTabletStatementGenerator.ramBytesUsed());
Review Comment:
```suggestion
```
##########
integration-test/src/test/java/org/apache/iotdb/relational/it/insertquery/IoTDBInsertQueryIT.java:
##########
@@ -86,7 +86,8 @@ public static void setUpClass() {
.getConfig()
.getCommonConfig()
.setPartitionInterval(1000)
- .setMemtableSizeThreshold(10000);
+ .setMemtableSizeThreshold(10000)
+ .setSelectIntoInsertTabletPlanRowLimit(1000);
Review Comment:
I think this parameter is stale, insert into query rows in table model,
shouldn't be limited by this parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
