Re: [PR] Pipe: Setup PipeLogger to reduce the selected pipe logs [iotdb]

Thu, 28 Aug 2025 05:32:14 -0700 


jt2594838 commented on code in PR #16296:
URL: https://github.com/apache/iotdb/pull/16296#discussion_r2307081810


##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/PipeTaskAgent.java:
##########
@@ -395,7 +396,8 @@ protected List<TPushPipeMetaRespExceptionMessage> 
handlePipeMetaChangesInternal(
               String.format(
                   "Failed to handle pipe meta changes for %s, because %s",
                   pipeName, e.getMessage());
-          LOGGER.warn("Failed to handle pipe meta changes for {}", pipeName, 
e);
+          PipeLogger.log(
+              LOGGER::warn, "Failed to handle pipe meta changes for %s\n%s", 
pipeName, e);

Review Comment:
   Notice that Log4j processes exceptions differently from String.format() .
   Especially that String.format() will not print the stack.
   
![img_v3_02pj_f9711b87-8fe3-47ed-b248-6eec17594b2g](https://github.com/user-attachments/assets/0122f9c3-ca6a-4f96-947f-00aaf62a95a5)
   
![img_v3_02pj_7994d30e-b4cf-4090-808d-3aa6dc3fef5g](https://github.com/user-attachments/assets/4550409d-5155-47e2-ac5e-60cf96ed680c)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to