jt2594838 commented on code in PR #16324:
URL: https://github.com/apache/iotdb/pull/16324#discussion_r2314737908
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java:
##########
@@ -116,9 +120,41 @@ public void init(int numThreads) {
recover();
}
+ /***
+ * Filter out pipe procedures that do not need to re-acquire lock and
re-execute when there are multiple locked pipe procedures during restore.
+ * @return non pipe procedures and one pipe procedure with max lock seq id
(if there is.)
+ */
+ private List<Procedure<Env>> filteredProcedureList(final
List<Procedure<Env>> procedures) {
+ List<Procedure<Env>> nonPipeOrLockedProcedures =
+ procedures.stream()
+ .filter(p -> !(p instanceof AbstractOperatePipeProcedureV2) ||
!p.isLockedWhenLoading())
+ .collect(Collectors.toList());
+
+ List<AbstractOperatePipeProcedureV2> lockedPipeProcedures =
+ procedures.stream()
+ .filter(p -> p instanceof AbstractOperatePipeProcedureV2 &&
p.isLockedWhenLoading())
+ .map(AbstractOperatePipeProcedureV2.class::cast)
+ .collect(Collectors.toList());
+ Optional<Procedure<Env>> maxPipeProcedure =
+ lockedPipeProcedures.stream()
+
.max(Comparator.comparingLong(AbstractOperatePipeProcedureV2::getLockSeqId))
+ .map(p -> (Procedure<Env>) p);
+
+ if (lockedPipeProcedures.size() > 1) {
+ LOG.warn(
+ "[Procedure restore]Detected multiple locked pipe procedures in
procedure executor {}, only keep last one {}",
+ lockedPipeProcedures,
+ maxPipeProcedure.get());
+ }
Review Comment:
Other lockedPipeProcedures should be cleaned up (removing their disk files).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
