JackieTien97 commented on code in PR #17348:
URL: https://github.com/apache/iotdb/pull/17348#discussion_r2985193711
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/IQueryExecution.java:
##########
@@ -66,6 +66,10 @@ public interface IQueryExecution {
*/
long getTotalExecutionTime();
+ String getClientHostname();
Review Comment:
add some comments to indicate that this function return ip for thrift-base
client, client-id for MQTT/REST client.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/header/ColumnHeaderConstant.java:
##########
@@ -496,10 +498,12 @@ private ColumnHeaderConstant() {
public static final List<ColumnHeader> showQueriesColumnHeaders =
ImmutableList.of(
- new ColumnHeader(QUERY_ID, TSDataType.TEXT),
+ new ColumnHeader(QUERY_ID, TSDataType.STRING),
Review Comment:
change back to TEXT, to let old version session to succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]