Adar Dembo has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG
Commit Message:

Line 15:    logging, so I added an equivalent field to the response protocol.
> I'm not super keen on changing the RPC protocol to avoid the extra paramete
Can I just drop the peer uuid argument altogether then? It's only used for 
logging.

If not dropped, a user who wants to remote bootstrap from the command line 
needs to provide it...just so it'll appear in some log messages.


-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to