Alexey Serbin has posted comments on this change. Change subject: [util] fixed build on MacOS X ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: Line 209: dl > weird... Adar asked if I needed to put this here, and I figured I didn't be At my laptop the error looks like ld: library not found for -ldl_exported clang: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [lib/exported/libkudu_client.0.1.0.dylib] Error 1 make[1]: *** [src/kudu/client/CMakeFiles/kudu_client_exported.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... So, it seems the problem arises later when working with ADD_EXPORTABLE_LIBRARY for EXPORTED_UTIL_LIBS if we leave the 'dl' lib in the list of UTIL_LIBS. Why target_link_libraries() does not brake on MacOS X -- I have no idea. -- To view, visit http://gerrit.cloudera.org:8080/3836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
