Todd Lipcon has submitted this change and it was merged. Change subject: c++ client: remove unnecessary code ......................................................................
c++ client: remove unnecessary code 1. GetTableSchema() was implemented using its own RPC instead of a much simpler call to SyncLeaderMasterRpc(). An RPC is attractive for asynchronous use, but since it's never used that way, let's just switch over to SyncLeaderMasterRpc(). 2. KuduTable::Open() was issuing both GetTableSchema() and GetTableLocations() RPCs. It's not clear why we're doing the latter; the response is completely ignored. So let's stop doing that. My main motivation is to remove fragile error-handling and retry logic which has been duplicated all over the client. Change-Id: Idda2cc15bc6224df992bfe2eec287c0222adced0 Reviewed-on: http://gerrit.cloudera.org:8080/3809 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <aser...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/client/client-internal.cc M src/kudu/client/client.cc M src/kudu/client/table-internal.cc M src/kudu/client/table-internal.h 4 files changed, 34 insertions(+), 304 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Alexey Serbin: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idda2cc15bc6224df992bfe2eec287c0222adced0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
