Mike Percy has posted comments on this change.
Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3868/1//COMMIT_MSG
Commit Message:
Line 17: This is safe, but an incompatible change, but we don't bump
Code will still link / compile so this isn't API or ABI compatible. It's just a
semantics change.
http://gerrit.cloudera.org:8080/#/c/3868/1/src/kudu/common/partial_row.h
File src/kudu/common/partial_row.h:
Line 108: // must remain valid until data for corresponding RPC calls are
generated.
Isn't the rule that the data must remain valid until the corresponding RPC
calls are completed and as long as the error buffers may be accessed? Since I
think (but am not sure) that the error buffers would refer to the uncopied data.
--
To view, visit http://gerrit.cloudera.org:8080/3868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I764339a0e3ffbf6abd5372e682c9fa1792bdd52b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes
