Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#6). Change subject: C++ client: deprecating KuduPartialRow::SetString() ...................................................................... C++ client: deprecating KuduPartialRow::SetString() KuduPartialRow::Set{String,Binary}() are marked as deprecated. Use KuduPartialRow::Set{String,Binary}NoCopy() instead. KuduPartialRow::SetString()/SetBinary() behavior is optimized to make no copies of the passed data. However, a user of the API might assume they are safe to use along with other setters as SetInt32, SetDouble, etc. where the string or binary data goes out of scope (or deallocated) before AppendToPB() is called. To play safe, new methods are introduced instead: KuduPartialRow::Set{String,Binary}NoCopy(). The new names contain a hint about the optimized behavior of these methods. An alternative approach might be to change behavior of KuduPartialRow::Set{String,Binary}() and introduce only KuduPartialRow::Set{String,Binary}NoCopy(), but there are concerns about compatibility and performance regressions. Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c --- M src/kudu/client/predicate-test.cc M src/kudu/common/key_util-test.cc M src/kudu/common/partial_row-test.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/row_operations-test.cc M src/kudu/integration-tests/client_failover-itest.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/integration-tests/write_throttling-itest.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/major_delta_compaction-test.cc M src/kudu/tserver/tablet_copy_session-test.cc 12 files changed, 179 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/3723/6 -- To view, visit http://gerrit.cloudera.org:8080/3723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>