Mike Percy has posted comments on this change.
Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data
......................................................................
Patch Set 9:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3868/9/src/kudu/common/partial_row-test.cc
File src/kudu/common/partial_row-test.cc:
Line 47: typedef Status (KuduPartialRow::*BinarySetter)(int, const Slice&);
hrm, would you mind removing the space between Status and the opening paren?
Also I'm not sure I fully understand how this typedef works but I'll ask you on
chat
Line 78: case COPY:
style nit: indent case per
https://google.github.io/styleguide/cppguide.html#Loops_and_Switch_Statements
Line 98: case COPY:
same
--
To view, visit http://gerrit.cloudera.org:8080/3868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I764339a0e3ffbf6abd5372e682c9fa1792bdd52b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes
