Todd Lipcon has posted comments on this change. Change subject: Reorganize range partition client API ......................................................................
Patch Set 4: Code-Review+1 (2 comments) basically just looked at the API, rather than the impl, since it looks like Adar's already looking through the impl. API looks good. http://gerrit.cloudera.org:8080/#/c/3882/4/src/kudu/client/client.h File src/kudu/client/client.h: PS4, Line 558: Object KuduTableCreator http://gerrit.cloudera.org:8080/#/c/3882/4/src/kudu/common/row_operations-test.cc File src/kudu/common/row_operations-test.cc: Line 120: enc.Add(RowOperationsPB::UPSERT, row); hrm, upsert already listed -- To view, visit http://gerrit.cloudera.org:8080/3882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic731f0abcbb81cd4238cc960b150bf8cd1c1f0ea Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
