Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker ......................................................................
Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: Line 109: request_id.seq_no(), Your change to push a MemTrackerAllocator into ClientState means the per-client record map is tracked properly, but I think it ignores the actual ClientState allocation (i.e. the "new ClientState()) performed on L101. I don't see how that's tracked now, either through the MemTrackerAllocator built into clients_, or the allocator created for each ClientState. Line 296: See above. http://gerrit.cloudera.org:8080/#/c/3627/20/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: PS20, Line 57: auto release = memory_before - tracked->memory_footprint(); : tracker->Release(release); Seems like an odd stylistic change, but OK. -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
