Todd Lipcon has posted comments on this change. Change subject: fs: allow format with arbitrary uuid ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3968/2/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: Line 326: metadata->set_uuid(uuid.get()); do we want any kind of validation on UUID format? I think limiting to /[0-9a-z]{,30}/ or somesuch might be a good idea, just so people dont end up doing something bizarre like putting binary or '<>' in there (it's frequently logged with no escaping since we previously assumed it was an internally-generated ID) -- To view, visit http://gerrit.cloudera.org:8080/3968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4189d6150a263b7dde304dd19a449d3c0ab6c8c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
