Todd Lipcon has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3976/2/src/kudu/common/generic_iterators-test.cc File src/kudu/common/generic_iterators-test.cc: Line 226: TEST(TestMergeIterator, TestMergePredicate2) { > This test passes for me without the fix. oops, thanks for checking. when I did some test cleanup, I lost the 'set_block_size(10)' call on the VectorIterator. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/3976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07651ef4451609d8228b5e0f0de022970db4ebcf Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Anonymous Coward #80 Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
