Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: Line 426: void ResultTracker::StartGCThread() { Can't we put this in an Init() style method that is assumed to be single-threaded, so that gc_thread_ needn't be protected by lock_? Actually, a concurrent invocation would crash in the CHECK, so what's the point of the lock? -- To view, visit http://gerrit.cloudera.org:8080/3961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia34ce95e78920596eb8b9db53643845f637c8e6c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
