Adar Dembo has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: Line 57: for (const auto& gflag : action.gflags) { > what about using google::DescribeOneFlag for this? It handles nice line-wra Pretty neat. I did retain the majority of this code, though, to provide a nicer usage string. What do you think of this? adar@adar-ThinkPad-T540p:~/Source/kudu/build/debug$ bin/kudu fs print_uuid --help Usage: bin/kudu fs print_uuid [-fs_wal_dir=<dir>] [-fs_data_dirs=<dirs>] Print the UUID of a Kudu filesystem -fs_wal_dir (Directory with write-ahead logs. If this is not specified, the program will not start. May be the same as fs_data_dirs) type: string default: "" -fs_data_dirs (Comma-separated list of directories with data blocks. If this is not specified, fs_wal_dir will be used as the sole data block directory.) type: string default: "" http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: Line 203: tablet_print_peer_uuids.name = "print_uuids"; > Isn't this more accurately 'replica uuids', since I think it contains all r Changed to "print_replica_uuids". Line 204: tablet_print_peer_uuids.description = "Print the uuids from a tablet's Raft configuration"; > UUIDs of the peers Done -- To view, visit http://gerrit.cloudera.org:8080/3969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
