Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC ......................................................................
Patch Set 15: > > > Could you also add a GCing thread to mt-tablet-test? It's a > good > > > way to test interactions between concurrent tablet operations. > > > > There's no new dedicated GC task yet. The GCing happens as part > of > > flush and compaction. That new MM task is coming later. > > mt-tablet-test doesn't invoke MM tasks though; it just calls public > Tablet methods. I only skimmed this patch but I think it adds > everything needed to extend the test. The way we would do it is simply set the tablet_history_max_age to some low value like 1 or 2 in the test, I guess. Everything else would be automatic, assuming it's already using HybridTime. That's something I can do. -- To view, visit http://gerrit.cloudera.org:8080/3076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9833a863f118eb82be80ea56204d0d9141611c2 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
