Adar Dembo has posted comments on this change. Change subject: catalog_manager: avoid race in InitSysCatalogAsync() and GetTabletPeer() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3997/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 706: sys_catalog_.reset(new_catalog.release()); > Purely looking from this context alone, would this race be seen if we were When I first wrote this patch, I thought the race was with Shutdown() and then I'd be inclined to agree (in that sys_catalog_ would be destroyed only when the last owner loses its ref). But since then, I've found the root cause of the race and I don't think changing the ownership semantics would actually change anything. -- To view, visit http://gerrit.cloudera.org:8080/3997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43fdc6499cb84d2053bed08b689fe5a08a6761d6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
