Adar Dembo has posted comments on this change. Change subject: Convert pbc-dump over to new tool infrastructure ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4037/1/src/kudu/tools/CMakeLists.txt File src/kudu/tools/CMakeLists.txt: Line 90 Note that removing the executable will cause the packaging builds to fail. If you're interested in preventing that, you should first modify install_kudu.sh (CDH/cdh-package.git:kudu) to stop copying kudu-pbc-dump. http://gerrit.cloudera.org:8080/#/c/4037/1/src/kudu/tools/tool_action.h File src/kudu/tools/tool_action.h: Line 253: // Returns a new "pbc" mode node. I was thinking that modes would correspond directly to contexts. Which means, kudu-pbc-dump would be lumped under a "file" context along with all other operations that operate on a single file by name (e.g. log-dump when called on a segment directly). Alternatively, we could recognize that "fs" and "file" are similar and reuse "fs". What do you think? Line 254: std::unique_ptr<Mode> BuildPbcMode(); Nit: The comments for each of these aren't going to be useful. Let's just combine them like so: // Returns new nodes for each major mode. std::unique_ptr<Mode> BuildFooMode(); std::unique_ptr<Mode> BuildBarMode(); ... And let's also keep the modes sorted in alphabetical order. -- To view, visit http://gerrit.cloudera.org:8080/4037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
