Alexey Serbin has posted comments on this change. Change subject: tool: improve help output ......................................................................
Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/4038/1//COMMIT_MSG Commit Message: Line 9: - adds blank line in between usage summary and more detail nit for consistency: adds --> add, or justify --> justifies below instead http://gerrit.cloudera.org:8080/#/c/4038/1/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: Line 94: std::stringstream msg; nit: std::ostringstream since no input is assumed. PS1, Line 95: [<args>] nit: if here we are using mandatory/optional notation with <>/[] brackets, what [<args>] would mean? I would expect it to be just $0 <command> [args] instead. Line 96: msg << "<command> can be one of the following:\n"; nit: " <command> ..." i.e. add a couple of spaces for better readability in the beginning of the line. -- To view, visit http://gerrit.cloudera.org:8080/4038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b4fc2da2b03edf8ce6b9998eeabd06a4fcd216d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
