Todd Lipcon has posted comments on this change. Change subject: subprocess: allow Call() to read both stdout and stderr ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4057/1/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 187: // Interrupted by a signal, do nothing. is this the appropriate thing instead of retrying on EINTR? (like RETRY_ON_EINTR macro in env_posix.cc) Line 487: *stdout_out = out[0]; maybe std::move or a swap() makes sense here just cuz the output could be large -- To view, visit http://gerrit.cloudera.org:8080/4057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5f2be94c2e5cc0644a5bb2340adc4a71d844247 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
