Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4100
to review the following change.
Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags
......................................................................
KUDU-1231. Add "unlock" flag for experimental and unsafe flags
This adds two new flags:
--unlock_experimental_flags
--unlock_unsafe_flags
If a flag is tagged as 'unsafe' or 'experimental', and the user tries
to set this flag on the command line without the corresponding 'unlock'
flag being set, then the process will exit at startup with an error.
Example error output without unsafe flags unlocked:
E0823 15:12:08.163079 28376 flags.cc:300] Flag --never_fsync is unsafe
and unsupported.
E0823 15:12:08.163204 28376 flags.cc:301] Use --unlock_unsafe_flags to
allow this flag at your own risk.
<exits>
Example error output with flag unlocked:
W0823 15:12:47.344476 28382 flags.cc:304] Enabled unsafe flag:
--never_fsync=true
Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
---
M docs/release_notes.adoc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/util/flags.cc
3 files changed, 59 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/4100/1
--
To view, visit http://gerrit.cloudera.org:8080/4100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
