Alexey Serbin has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4105/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1011: /// @note This class is not thread-safe except where otherwise specified. > Should this be removed too? Replaced with 'This class is not thread-safe.' per Dan's recommendation. PS2, Line 1011: /// @note This class is not thread-safe except where otherwise specified. > or change it to Done, thanks! -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Binglin Chang <decst...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes