Dan Burkert has posted comments on this change. Change subject: java: fix leak of TabletClient objects in client2tablets map ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4119/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java: Line 45: protected static final Logger LOG = LoggerFactory.getLogger(BaseKuduTest.class); Is this necessary? It doesn't look like you actually use it. I think we typically create loggers in individual tests classes if they need it. -- To view, visit http://gerrit.cloudera.org:8080/4119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I302650f2a6526e7c51537264137a4f00cbbda073 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
