Mike Percy has submitted this change and it was merged.
Change subject: Remove pessimizing std::move() in return statement
......................................................................
Remove pessimizing std::move() in return statement
This change fixes this Clang warning:
[334/463] Building CXX object
src/kudu/consensus/CMakeFiles/raft_consensus_quorum-test.dir/raft_consensus_quorum-test.cc.o
../../src/kudu/consensus/raft_consensus_quorum-test.cc:534:12: warning: moving
a local object in a return statement prevents copy elision [-Wpessimizing-move]
return std::move(cmeta);
^
../../src/kudu/consensus/raft_consensus_quorum-test.cc:534:12: note: remove
std::move call here
return std::move(cmeta);
^~~~~~~~~~ ~
1 warning generated.
Change-Id: Ida46588398ca5f5982cb86aa03825530565c0923
Reviewed-on: http://gerrit.cloudera.org:8080/4122
Reviewed-by: Todd Lipcon <t...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/raft_consensus_quorum-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida46588398ca5f5982cb86aa03825530565c0923
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
