Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC ......................................................................
Patch Set 6: (2 comments) TFTR Adar, will follow the JIRA suggestions for more testing tonight. http://gerrit.cloudera.org:8080/#/c/4099/6/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: PS6, Line 124: const int kNumServers = 3; : const int kNumTablets = 3; > Why did you change these values? Oops, reverted. that shouldn't have gone in this branch. thanks. http://gerrit.cloudera.org:8080/#/c/4099/6/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: PS6, Line 513: std::string > Missed one. Hmmm... if you see this source(as well as header file), all the routines use std:;string. I would rather be consistent here although I know it's a moot namespace prefix here. I only removed return value to be string instead of std::string(again something followed by all other routines). We can prolly fix this in a different change may be? -- To view, visit http://gerrit.cloudera.org:8080/4099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I750eeb78c989daaa6fd5d9793b1218ae5993653c Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
