Todd Lipcon has posted comments on this change. Change subject: master: include TS address in log messages ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4131/1//COMMIT_MSG Commit Message: Line 15: server. > Thanks, yeah this is super useful while browsing logs with sclable nodes/ta the error paths in that function are all for the case where we can't find or register a TSDescriptor, so can't use the new function. We already use RpcContext::requestor_string which includes the hostname, though http://gerrit.cloudera.org:8080/#/c/4131/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 3492: return Substitute("Master P $0: ", > Hmm, I'm not so sure about this one. The Raft machinery will log as "T 0000 yea good point, will revert this part. -- To view, visit http://gerrit.cloudera.org:8080/4131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic55fa7e818a115de70f9fc6aca12581c3b4779c7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
