Adar Dembo has posted comments on this change. Change subject: docs: update installation with new OS support ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4128/1//COMMIT_MSG Commit Message: Line 10: 1. The SLES 12, Jessie, and Xenial Cloudera repo files contain unsubstituted > nit: could you make the lines in the detailed description to be less than 7 I admire your persistence, but I think you're fighting an uphill battle. We've been pretty consistently wrapping commit messages to 76 chars, or even 80. But, I can be convinced. What's the advantage of wrapping to 72? http://gerrit.cloudera.org:8080/#/c/4128/1/docs/installation.adoc File docs/installation.adoc: PS1, Line 43: When using replication, a minimum of : three masters is necessary. > I think we should explicitly recommend three or five. People might think it Done Line 113: provide the operating system commands to start and stop Kudu. > Nit: consider 'These packages provide configuration files along with init.d Bear in mind this is upstream documentation so we should mention CM only in passing. PS1, Line 115: O > O --> o ? I.e., why is the capital 'o' letter? And in other places with t No idea, I didn't write it. Will make the change. -- To view, visit http://gerrit.cloudera.org:8080/4128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f51b55561f18fbe28d6bf4ed507dfba65947dc0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
