Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4140
to review the following change.
Change subject: raft_consensus-itest: inserter thread should FATAL instead of
FAIL
......................................................................
raft_consensus-itest: inserter thread should FATAL instead of FAIL
This test has a thread which inserts rows and is supposed to fail the
test case if it sees any row errors. Failing the test using FAIL() from
a non-main thread is not thread-safe in gtest. Furthermore, FAIL() acts
as a 'return' and thus the latch used to communicate the thread
completion never gets fired. So, when this assertion failed, the test
would hang forever.
This was a regression caused by d0cff255f84e75b70c0c39ccd34a35f348e3c722
which changed the code from a CHECK(...) to a FAIL().
In order to correct this behavior, this patch switches to using the
utility method FlushSessionOrDie() which has an identical
implementation.
Change-Id: I9dbe1e551b7f1b8b81ce0156627deb096db5112b
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 1 insertion(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/4140/1
--
To view, visit http://gerrit.cloudera.org:8080/4140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dbe1e551b7f1b8b81ce0156627deb096db5112b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
