Todd Lipcon has posted comments on this change. Change subject: KUDU-687: use client in ksck for master operations ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4147/1//COMMIT_MSG Commit Message: Line 17: comma-separated list, to be more consistent with --master_addresses. yea, I think I prefer comma-separated since it's the same way we specify it everywhere else (and in other tools) http://gerrit.cloudera.org:8080/#/c/4147/1/src/kudu/integration-tests/mini_cluster.cc File src/kudu/integration-tests/mini_cluster.cc: PS1, Line 294: * style http://gerrit.cloudera.org:8080/#/c/4147/1/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: Line 284: for (auto s : servers) { const auto& Line 324: for (auto t : tokens) { const auto& Line 328: for (const auto r : t->tablet().replicas()) { auto& -- To view, visit http://gerrit.cloudera.org:8080/4147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbd6b28ea1b2c88e02cd451095e4dec94b0ebfc3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
