Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags ......................................................................
KUDU-1231. Add "unlock" flag for experimental and unsafe flags This adds two new flags: --unlock_experimental_flags --unlock_unsafe_flags If a flag is tagged as 'unsafe' or 'experimental', and the user tries to set this flag on the command line without the corresponding 'unlock' flag being set, then the process will exit at startup with an error. Example error output without flags unlocked: E0824 14:04:57.263624 14821 flags.cc:296] Flag --never_fsync is unsafe and unsupported. E0824 14:04:57.263749 14821 flags.cc:302] 1 unsafe flag(s) in use. E0824 14:04:57.263761 14821 flags.cc:303] Use --unlock_unsafe_flags to proceed at your own risk. E0824 14:04:57.264104 14821 flags.cc:296] Flag --local_ip_for_outbound_sockets is experimental and unsupported. E0824 14:04:57.264128 14821 flags.cc:302] 1 experimental flag(s) in use. E0824 14:04:57.264137 14821 flags.cc:303] Use --unlock_experimental_flags to proceed at your own risk. <exits> Example error output with flags unlocked: W0824 14:04:42.922560 14773 flags.cc:294] Enabled unsafe flag: --never_fsync=true W0824 14:04:42.923032 14773 flags.cc:294] Enabled experimental flag: --local_ip_for_outbound_sockets=127.0.0.1 <continues> Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6 Reviewed-on: http://gerrit.cloudera.org:8080/4100 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Todd Lipcon <t...@apache.org> --- M docs/release_notes.adoc M java/kudu-client/src/test/resources/flags M python/kudu/tests/common.py M src/kudu/client/client_samples-test.sh M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/util/flag_tags-test.cc M src/kudu/util/flag_tags.h M src/kudu/util/flags.cc 8 files changed, 136 insertions(+), 5 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/4100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
