Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4167 to look at the new patch set (#2). Change subject: tool: port log-dump ...................................................................... tool: port log-dump This one was more complicated, because log-dump can run against a single file or an entire tablet. So I put all the common functionality in one place and referenced it from both modes. I consolidated similar gflags where it made sense to do so, and I tweaked the endline handling for help generation so that each parameter is separated from the next with an empty line. Semantic changes from log-dump: - If called with print_entries=no, will also print the footer. - The print_headers flag is now print_meta, to be more consistent with 'kudu cfile dump'. Change-Id: I14f048169c0b211e3c72fcd255c76dd59cbb05c9 --- M docs/release_notes.adoc M src/kudu/consensus/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action.cc M src/kudu/tools/tool_action.h R src/kudu/tools/tool_action_common.cc A src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_fs.cc M src/kudu/tools/tool_action_tablet.cc A src/kudu/tools/tool_action_wal.cc M src/kudu/tools/tool_main.cc M src/kudu/util/test_macros.h 13 files changed, 440 insertions(+), 160 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4167/2 -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I14f048169c0b211e3c72fcd255c76dd59cbb05c9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>