Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata ......................................................................
Patch Set 17: (2 comments) TFTRs Mike/Dan/Adar, updated the patch to reflect the discussions we have had on this. Please take a look. http://gerrit.cloudera.org:8080/#/c/3823/15/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: PS15, Line 313: CHECK_EQ(table_id_, superblock.table_id()); : PartitionSchema partition_schema; : RETURN_NOT_OK(PartitionSchema::FromPB(superblock.partition_schema(), : *schema_, &partition_schema)); : CHECK(partition_schema_.Equals(partition_schema)); : : Partition partition; : Partition::FromPB(superblock.partition(), &partition); : CHECK(partition_.Equals(partition)); > Providing equals on partition should be easy, it just needs to check that t also checked for hash_buckets equality Dan, assuming that's immutable as well. PS15, Line 313: CHECK_EQ(table_id_, superblock.table_id()); : PartitionSchema partition_schema; : RETURN_NOT_OK(PartitionSchema::FromPB(superblock.partition_schema(), : *schema_, &partition_schema)); : CHECK(partition_schema_.Equals(partition_schema)); : : Partition partition; : Partition::FromPB(superblock.partition(), &partition); : CHECK(partition_.Equals(partition)); > I suppose we could change this to CHECK and just rely on upgrade / downgrad Cool, thanks Mike, updated the code with Equals() for both partition and partition_schema, and moving to CHECK to keep the code same for all build types. I agree with catching the compat issues with white/black box automated tests for upgrade/downgrade. -- To view, visit http://gerrit.cloudera.org:8080/3823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
