Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks ......................................................................
Patch Set 4: (4 comments) I am still working my way through this patch. There are several TODOs, not sure if you know the answers to those yet. But I will investigate when I pick up again on reviewing the logic changes in this patch. http://gerrit.cloudera.org:8080/#/c/4133/4/src/kudu/consensus/consensus.proto File src/kudu/consensus/consensus.proto: Line 333: // The id of the last committed operation in the configuration. This is the s/id/index/ Line 334: // id of the last operation the leader deemed committed from a consensus s/id/index/ http://gerrit.cloudera.org:8080/#/c/4133/4/src/kudu/consensus/consensus_peers-test.cc File src/kudu/consensus/consensus_peers-test.cc: Line 142: message_queue_->SetLeaderMode(0, 0, BuildRaftConfigPBForTests(3)); Maybe better to use kMinimumTerm and kMinimumOpIdIndex from opid_util.h here and elsewhere http://gerrit.cloudera.org:8080/#/c/4133/4/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: Line 415: // TODO: doc me todo -- To view, visit http://gerrit.cloudera.org:8080/4133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2aa294472f018013d88f36a9358e9ebd9d5ed8f8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
