Alexey Serbin has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4180/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: PS1, Line 205: &stderr_ignored nit: consider using nullptr instead http://gerrit.cloudera.org:8080/#/c/4180/1/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: Line 231: for (const auto& t : table_names) { nit: there is a piece of syntactic sugar for this, if you wish: std::copy(table_names.begin(), table_names.end(), std::ostream_iterator<std::string>(std::cout, "\n")); -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
