Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4173/1//COMMIT_MSG Commit Message: PS1, Line 16: ScanToken I'm having a hard time understanding this example- what would the partitioning be here? PS1, Line 17: lower-bound-primary-key=(string a=1, string b=3, string c=5), : upper-bound-primary-key=(string a=2, string b=4, string c=) If I'm not mistaken, these are implied by the partitioning, right? I guess these are less actionable, and maybe less useful... I wonder if it'd be more useful to put these after the hash buckets and range partitions. PS1, Line 25: I haven't added tests of the specific : format of the strings If we're considering this to be a stable-ish interface, or at least enough that Impala can depend on it, perhaps a few tests for the format of the strings would be worthwhile. http://gerrit.cloudera.org:8080/#/c/4173/1/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java File java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java: PS1, Line 401: ) ] this should close the [ on l385. -- To view, visit http://gerrit.cloudera.org:8080/4173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42014da270e66c370cc6d6ed68fb38331130ff6d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
