Todd Lipcon has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/2/src/kudu/common/column_predicate.h File src/kudu/common/column_predicate.h: Line 142: bool EvaluateCell(DataType physical_type, const void *cell) const; > I think you may want to define this method in the header, so that you can b hrm, yea if the callers are from outside this header, then you do need to include the definition in the header, or in a separate "column_predicate-inl.h" which would be included by anyone who needs the definition. Looking at the assembly output with gdb is probably a good idea to make sure it's inlining as expected -- To view, visit http://gerrit.cloudera.org:8080/4164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccfac9bc899362b442337050795b5ca8c4101268 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
