Adar Dembo has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/4134/9/src/kudu/tools/kudu-ts-cli-test.cc File src/kudu/tools/kudu-ts-cli-test.cc: Line 117: Status s; Not used? Line 127: ASSERT_EQ("", out); ASSERT_TRUE(out.empty()) is more idiomatic. Line 145: ASSERT_THAT(out, testing::ContainsRegex("int32 key=")); Here use the macros in test_macros.h to help out. ASSERT_STR_MATCHES() for example. -- To view, visit http://gerrit.cloudera.org:8080/4134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8470377400047236127dd409b4825c5c6ea6bbae Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
