Adar Dembo has posted comments on this change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4295/1/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: Line 209: }); > hrm, really? this is how my emacs indents it, for better or worse... you th Nah, if it's more consistent this way then keep it as-is. http://gerrit.cloudera.org:8080/#/c/4295/1/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: Line 190: void Cancel() { > was hoping that we can add some polling from within the ops themselves at s I see. Perhaps CancelAndDisable() or CancelAndStop() then? My beef with Cancel() as-is is just that it doesn't suggest the end of events in the future. To use a dumb metaphor, "the game was cancelled" doesn't imply that there won't be more games in the future. -- To view, visit http://gerrit.cloudera.org:8080/4295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3675705caf5b73f8a480036b974e4db6c205616a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
